Allow max angle limit of 0 for stepper mode#8
Merged
Conversation
According to their documentation in [STS3215_Memory_Table_EN.xlsx](https://github.com/alessiodam/python-st3215/blob/main/documents/STS3215_Memory_Table_EN.xlsx): _"When operating in mode 3, the minimum and maximum angle limits for 0x9 and 0xB must be set to 0; otherwise, infinite stepping is not possible."_. However when I try to set the max angle to 0 there is an error because there is a validation that the angle should be greater or equal to 0. This change relaxes this limitation.
Owner
|
Hello, thanks for your contribution! |
Owner
|
Your changes have been published in v1.2.1! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to their documentation in STS3215_Memory_Table_EN.xlsx: "When operating in mode 3, the minimum and maximum angle limits for 0x9 and 0xB must be set to 0; otherwise, infinite stepping is not possible.".
However when I try to set the max angle to 0 there is an error because there is a validation that the angle should be greater or equal to 0. This change relaxes this limitation.