Merged
Conversation
* make configuration settings cache variables to allow setting them externally, allowing to build against another version of OpenCascade easier * make the update_target_library hack conditional for Windows (other OSes usually have a package manager that takes care of installing the correct versions of libraries and doesn't need this * make the adjustments for the optional OpenCascade dependencies conditional according to the actual used OpenCascase configuration * replace the ugly post-build hack to copy DLLs with an actual "installation" to "install" these (the DLLs conditionally for Windows as well and optional)
Contributor
Author
|
I have tested these changes now on Linux (openSUSE Leap 15.2). Building works now without changes when using system packages. This version uses OpenCascade 7.3.0. The path variables are not used and not needed in this case. Maybe we should not define them when not on WIN32? |
* the actual runtime dependencies have not changed
tested on Haiku (using OCE 0.18.3) - note that it doesn't actually build on Haiku: it fails to link because the Haiku port of OCE misses some parts which would require X11 (or Windows)
jmairboeck
commented
Apr 26, 2021
…tional dependencies untested)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.