Hw1#1
Open
alexander-gileta wants to merge 3 commits into
Open
Conversation
rokymiel
reviewed
Mar 22, 2026
| ], message: "Главное меню:") | ||
|
|
||
| switch choice { | ||
| case 1: |
There was a problem hiding this comment.
Цифры лучше заменить на enum, чтобы иметь compile time проверки
rokymiel
reviewed
Mar 22, 2026
| } | ||
|
|
||
| class ConsoleUI { | ||
| func showMenuList(options: [String], message: String = "Выберите действие:") -> Int { |
rokymiel
reviewed
Mar 22, 2026
| if let input = readLine(), let choice = Int(input), choice > 0, choice <= options.count { | ||
| return choice | ||
| } else { | ||
| print("Неверный ввод. Попробуйте снова.") |
There was a problem hiding this comment.
Принт лучше инджектить в виде зависимости. Если вдруг захочешь это на CI потом. Там другой вывод в консоль может понадобиться
rokymiel
reviewed
Mar 22, 2026
| } | ||
| } | ||
|
|
||
| enum MenuState { |
There was a problem hiding this comment.
Когда много кода в одном файле (понимаю, что таково задание, но просто совет) – отдельные типы лучше выделять комментами. На iOS особенно и использовать // MARK: -
rokymiel
reviewed
Mar 22, 2026
| } | ||
| } | ||
|
|
||
| protocol CanvasUnit { |
There was a problem hiding this comment.
Что-то не нашел ответа на пункт "подумайте как лучше стоит реализовать это в iOS и в Android". поэтому по продвинутой части минус
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.