fix(): restrict CORS to localhost and prevent shell injection#50
Merged
Conversation
…tmux calls Close CSRF vector by replacing wildcard CORS with a localhost-only origin check. Replace execSync with execFileSync for git/tmux commands to prevent shell injection via branch names or paths. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexandrelam
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cors()with a localhost-only origin check, closing the CSRF vector where a malicious website could make fetch requests tolocalhost:3325/api/*execSyncwithexecFileSyncfor all git/tmux commands inworktree.ts, preventing shell injection via branch names, worktree paths, or tmux session namesexecFileSyncsignaturesTest plan
npm run buildcompiles cleannpx vitest run test/worktree.test.ts test/server-security.test.ts— all 20 tests passcurl -H "Origin: http://evil.com" -v http://localhost:3325/api/projects— should fail CORScurl -H "Origin: http://localhost:5173" -v http://localhost:3325/api/projects— should work🤖 Generated with Claude Code