8 спринт#3
Merged
Merged
Conversation
slavrikk
reviewed
Apr 23, 2025
| } | ||
|
|
||
| private final File file; | ||
| private final TreeSet<Task> prioritizedTasks; |
There was a problem hiding this comment.
Коллекция должна храниться в классе InMemoryTaskManager и все проверки по пересечению должны проводится только в нем
| } | ||
|
|
||
| @Override | ||
| public boolean isOverlapping(Task newTask) { |
There was a problem hiding this comment.
Метод следует указать как private + перенести в InMemoryTaskManager
| if (this.startTime == null || otherTask.startTime == null || this.duration == null || otherTask.duration == null) { | ||
| return false; | ||
| } | ||
| LocalDateTime thisEnd = this.startTime.plus(this.duration); |
There was a problem hiding this comment.
Можно использовать метод getEndTime()
| return false; | ||
| } | ||
| LocalDateTime thisEnd = this.startTime.plus(this.duration); | ||
| LocalDateTime otherEnd = otherTask.startTime.plus(otherTask.duration); |
There was a problem hiding this comment.
Можно использовать метод getEndTime()
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| class FileBackedTaskManagerTest { |
There was a problem hiding this comment.
- Этот класс должен наследовать
TaskManagerTest - Так же следует создать тестовый класс для InMemoryTaskManager, чтобы так же его унаследовать от
TaskManagerTest
slavrikk
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.