fix(ci): repair javadoc generation for release builds#301
Merged
Conversation
Release pipeline was failing at maven-javadoc-plugin:jar because the plugin cannot resolve Lombok-generated inner types (e.g. DashboardFileContent.DashboardFileContentBuilder) when the standard javadoc tool does not run the annotation processor. Wire lombok-maven-plugin into the central-publish profile to delombok sources during generate-sources, and point maven-javadoc-plugin at the delombok output plus the protobuf-generated sources so the release JAR can always be documented. Add a dedicated Javadoc GitHub workflow that runs the same central-publish package target on every PR and push to main, preventing future javadoc breakage from silently reaching a release tag.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-javadoc-plugin:jarin thecentral-publishprofile fails becausejavadocdoes not execute Lombok's annotation processor, so Lombok-generated inner types such asDashboardFileContent.DashboardFileContentBuilder(referenced inDashboardFileService) cannot be resolved. The last threeReleaseruns (feat(llm): add tier fallback routing settings #294, fix(prompts): coerce null description from YAML to empty string #297, fix(dashboard): add staged update force install #299) failed at exactly this step and never produced a tag.lombok-maven-plugin(pinned to the project${lombok.version}) to thecentral-publishprofile, delomboksrc/main/javaintotarget/delombokingenerate-sources, and pointmaven-javadoc-pluginat the delombok output + the protobuf-generated sources so the javadoc jar can always be built.javadoc.ymlworkflow runs the samemvn -P central-publish packagepath on every PR and push tomain, so a javadoc regression is now caught before it can reach a release tag.Verified locally:
./mvnw -B -ntp -DskipTests -DskipGitHooks=true -P central-publish packagesucceeds and emitstarget/bot-*-javadoc.jar.🤖 Generated with Claude Code