Open
Conversation
… before you try it out. ;)
Owner
|
Fantastic! I look forward to testing this out - although I don't currently
have a Launchpad (only Launchkey mini in front of me) - although I can
easily get my hands on one
…On Sun, Oct 1, 2017 at 1:59 PM, David Hilowitz ***@***.***> wrote:
Hi Alex,
I've finally managed to make a version of my Launchpad code that works
with your version of the SamplerBox codebase (great work on that, by the
way!). It relies on the grid-instrument library (which I wrote), which in
turn relies on launchpad_rtmidi.py library. Make sure to do pip install
grid-instrument before you try it out. ;)
All best,
Dave
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- Full Launchpad support. Make sure to do `pip install
grid-instrument` before you try it out. ;)
File Changes
- *M* config.ini
<https://github.com/alexmacrae/SamplerBox/pull/2/files#diff-0> (1)
- *M* modules/globalvars.py
<https://github.com/alexmacrae/SamplerBox/pull/2/files#diff-1> (1)
- *M* samplerbox.py
<https://github.com/alexmacrae/SamplerBox/pull/2/files#diff-2> (47)
Patch Links:
- https://github.com/alexmacrae/SamplerBox/pull/2.patch
- https://github.com/alexmacrae/SamplerBox/pull/2.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABeIKqnIEV9e2vOKosjjQRLZost_Sd_Vks5snwAHgaJpZM4Ppw5g>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Alex,
I've finally managed to make a version of my Launchpad code that works with your version of the SamplerBox codebase (great work on that, by the way!). It relies on the
grid-instrumentlibrary (which I wrote), which in turn relies onlaunchpad_rtmidi.pylibrary. Make sure to dopip install grid-instrumentbefore you try it out. ;)All best,
Dave