提出#106
Open
tsuuuru wants to merge 10 commits into
Open
Conversation
nanashima
requested changes
Jul 2, 2022
nanashima
left a comment
nanashima
left a comment
There was a problem hiding this comment.
spear.c works.c が正しく動いていません．
また，array.cは正しく動いているのですが，講義や資料の二分探索の(特にubとlbについての)解説を参考に余分な条件分岐を消してください．
| } | ||
|
|
||
| lb = 0; | ||
| ub = 1000000000; |
| } | ||
|
|
||
| lb = 0; | ||
| ub = 1000000; |
再提出しました。 よろしくお願いします。
修正しました。関数を新たに追加しました。よろしくお願いします。
こちらも初期値を修正しました。よろしくお願いします。
Author
|
spear.c works.c array.cの修正をしました。 |
nanashima
requested changes
Jul 15, 2022
| ub = n; | ||
| while(ub - lb > 1){ | ||
| int mid = (lb + ub)/2; | ||
| if(A[mid] > k) ub = mid; |
Author
There was a problem hiding this comment.
17行目
if(A[mid] >= k) ub = mid;
に修正しました。確認よろしくお願いします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
関数名に悩みました
二分探索のコードがとても覚えやすかったです