Skip to content

fix(dashboard): reset field values when switching circuit breaker strategy #3605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daguimu wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

fix(dashboard): reset field values when switching circuit breaker strategy #3605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sentinel-dashboard/src/main/webapp/resources/app/scripts/controllers/degrade.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,11 @@ app.controller('DegradeCtl', ['$scope', '$stateParams', 'DegradeService', 'ngDia
});
};

$scope.onGradeChange = function () {
$scope.currentRule.count = undefined;
$scope.currentRule.slowRatioThreshold = undefined;
};

$scope.saveRule = function () {
if (!DegradeService.checkRuleValid($scope.currentRule)) {
return;
Expand Down
6 changes: 3 additions & 3 deletions sentinel-dashboard/src/main/webapp/resources/app/views/dialog/degrade-rule-dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
<label class="col-sm-2 control-label">熔断策略</label>
<div class="col-sm-9">
<div class="form-control highlight-border" align="center">
<input type="radio" name="grade" value="0" checked ng-model='currentRule.grade' title="慢调用比例（1.8.0+ 版本生效）" />&nbsp;慢调用比例&nbsp;&nbsp;
<input type="radio" name="grade" value="1" ng-model='currentRule.grade' title="异常比例" />&nbsp;异常比例&nbsp;&nbsp;
<input type="radio" name="grade" value="2" ng-model='currentRule.grade' title="异常数" />&nbsp;异常数
<input type="radio" name="grade" value="0" checked ng-model='currentRule.grade' ng-change="onGradeChange()" title="慢调用比例（1.8.0+ 版本生效）" />&nbsp;慢调用比例&nbsp;&nbsp;
<input type="radio" name="grade" value="1" ng-model='currentRule.grade' ng-change="onGradeChange()" title="异常比例" />&nbsp;异常比例&nbsp;&nbsp;
<input type="radio" name="grade" value="2" ng-model='currentRule.grade' ng-change="onGradeChange()" title="异常数" />&nbsp;异常数
</div>
</div>
</div>
Expand Down