style(sight): apply rustfmt + clippy -D warnings#726
Open
jfeng18 wants to merge 2 commits into
Open
Conversation
2 tasks
jfeng18
force-pushed
the
chore/sight-lint-v2
branch
3 times, most recently
from
bd304f2 to
c7f7c91
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jfeng18
force-pushed
the
chore/sight-lint-v2
branch
from
c7f7c91 to
784fd10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshed on latest main (supersedes #668). Applies
cargo fmt+cargo clippy --fix+ manual fixes to make the agentsight crate fully rustfmt + clippy -D warnings clean.Changes
cargo fmton all 100+ source filescargo clippy --fixfor auto-fixable lints (format strings, vec init, etc.)strip_prefix,&Pathinstead of&PathBuf, doc indentation#[allow]for generated BPF skeleton lintsNot changed
Test plan
cargo clippy -- -D warnings= 0 errorscargo fmt --check= cleanSupersedes #668