WIP: Add Skill Ledger activation daemon#857
Draft
1570005763 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP: adds daemon-side Skill Ledger activation refresh for SkillFS change notifications.
This PR wires
skill_ledger.skillfs_notify_changeinto the existingagent-sec-daemonUnix socket + NDJSON registry. The handler validates SkillFS change payloads, ignores metadata-only changes, queues work into a debounced activation job, runs Skill Ledger scan/activation refresh in the daemon background worker, and keeps.skill-meta/activation.json/ xattr updated without exposing aresolveCLI.It also updates the Skill Ledger / SkillFS activation design docs to describe the implemented daemon method, response semantics, debounce/reconcile behavior, and SkillFS interface boundaries.
Related Issue
no-issue: staged daemon activation implementation.
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)ckpt(ws-ckpt)memory(agent-memory)anolisa(anolisa-cli)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpassmemory(Linux only):cargo clippy --all-targets -- -D warnings,cargo fmt --check, andcargo testpassanolisa:cargo clippy --all-targets --locked -- -D warnings,cargo fmt --all --check, andcargo test --lockedpasspackage-lock.json/Cargo.lock)Testing
make python-code-prettygit diff --checkTMPDIR=/tmp PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --project agent-sec-cli pytest -q -p pytest_cov.plugin -p no:cacheprovider tests/unit-test/daemon/test_skill_ledger_activation.py tests/unit-test/daemon/test_client_server.py tests/integration-test/skill-ledger/test_skill_ledger_daemon_integration.py tests/e2e/daemon/test_daemon_e2e.pyTMPDIR=/tmp PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 uv run --project agent-sec-cli pytest -q -p pytest_cov.plugin -p no:cacheprovider tests/unit-test/skill_ledger tests/integration-test/skill-ledgerTMPDIR=/tmp uv run --project agent-sec-cli python3 tests/e2e/skill-ledger/e2e_test.pyAdditional Notes
make python-lintis not used as a gate here because the repository currently has pre-existing lint findings outside this change. The modified Python files were checked separately with ruff.