refactor: validate label / edge-triplet IDs at PropertyGraph API boundary

[zhanglei1949]

What do these changes do?

Harden PropertyGraph's label-id and edge-triplet validation so that bad caller-supplied IDs no longer become undefined behavior in Release builds, and unify the existing private check helpers so the string and label_t overloads behave consistently.

• Add label_t overloads of the private helpers and make all four overloads const. Both edge_triplet_check overloads now delegate per-vertex validation to vertex_label_check, so they share logic and produce equally granular errors:

  Status vertex_label_check(const std::string&) const;
  Status vertex_label_check(label_t) const;
  Status edge_triplet_check(const std::string&, const std::string&,
                            const std::string&) const;
  Status edge_triplet_check(label_t, label_t, label_t) const;

• Mutating APIs (BatchAddVertices, BatchDeleteVertices, DeleteVertex ×2, DeleteEdge, BatchDeleteEdges ×2, AddVertex, UpdateVertexProperty, UpdateEdgeProperty) now RETURN_IF_NOT_OK(vertex_label_check(...) / edge_triplet_check(...)) instead of assert(...) or relying on the callee to catch the bad ID.
• Non-Status accessors (get_vertex_table ×2, GetVertexPropertyColumn ×2, GetVertexSet, LidNum, VertexNum, IsValidLid, get_lid, GetOid) now call schema_.ensure_vertex_label_valid(...) (throws InvalidArgumentException) — the only viable signal channel for non-Status returns.
• GetVertexPropertyColumn(label, col_id) additionally bounds-checks col_id against the label's property count.
• Unify error wording across overloads: "Vertex label '<name>' is not valid" / "Vertex label id <N> is not valid"; same "Edge triplet <...> is not valid" shape. Drop the LOG(ERROR) calls from the existing string-based helpers (caller decides).

No behavior change for valid inputs. Verified no tests assert on the old error wording.

Background

These changes were originally bundled inside the zl/update-txn-cow branch (PR #370 split work) but have no semantic dependency on the workspace/checkpoint or COW refactor. Splitting them out keeps those downstream PRs focused and lets this hardening land independently against main.

Related issue number

Fixes #421

[Copilot]

Pull request overview

This PR hardens PropertyGraph’s public API boundary by validating caller-supplied vertex label IDs and edge-triplet IDs before they can trigger undefined behavior (especially in Release builds where assert is compiled out), and it consolidates the internal validation helpers so string- and label_t-based call sites behave more consistently.

Changes:

• Introduces label_t overloads for vertex_label_check / edge_triplet_check and makes the helpers const, with edge-triplet checks delegating per-vertex validation to vertex_label_check.
• Replaces a number of assert(...)-based checks in mutating APIs with RETURN_IF_NOT_OK(...) so invalid inputs return ERR_INVALID_ARGUMENT rather than risking UB.
• Adds label validation for non-Status accessors via schema_.ensure_vertex_label_valid(...), and adds a new bounds check in GetVertexPropertyColumn(label, col_id).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/storages/graph/property_graph.cc	Replaces assert-based validation with Status-returning checks; adds unified helper implementations for label/triplet validation.
include/neug/storages/graph/property_graph.h	Adds label validation to inline accessors and introduces a new column-id bounds check for GetVertexPropertyColumn(label, col_id).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[zhanglei1949]

returning null or throw exception?