[ui] Attribute: Refacto of the validation process, using the new validation paradigm#1875
Open
nicolas-lambert-tc wants to merge 1 commit intodevelopfrom
Open
[ui] Attribute: Refacto of the validation process, using the new validation paradigm#1875nicolas-lambert-tc wants to merge 1 commit intodevelopfrom
nicolas-lambert-tc wants to merge 1 commit intodevelopfrom
Conversation
Closed
7 tasks
nicolas-lambert-tc
force-pushed
the
feature/node-valididy-check
branch
from
e7b308d to
073e6a3
Compare
nicolas-lambert-tc
requested review from
cbentejac,
fabiencastan,
mh0g and
servantftransperfect
fabiencastan
requested changes
Jun 14, 2025
Member
fabiencastan
left a comment
fabiencastan
left a comment
There was a problem hiding this comment.
minor adjustments needed
nicolas-lambert-tc
force-pushed
the
feature/node-valididy-check
branch
from
073e6a3 to
e2ea36b
Compare
7 tasks
nicolas-lambert-tc
force-pushed
the
feature/node-valididy-check
branch
from
e2ea36b to
17cd0d7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors several Meshroom UI nodes to use the newer attribute validation paradigm (validators returning success()/error()) instead of legacy validValue/errorMessage fields.
Changes:
- Added a shared HDR bracket-count validator (
NbOfBracketsShouldBeAMultipleOfNbOfImages) in a new common module. - Updated LdrToHdr nodes (Sampling/Merge/Calibration) to use the shared validator instead of
errorMessageand removed legacyvalidValuehandling. - Updated
KeyframeSelectionoutput extension validation to the new validators API.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| meshroom/aliceVision/ldrToHdrCommon.py | Introduces a reusable validator for bracket/image-count consistency. |
| meshroom/aliceVision/LdrToHdrSampling.py | Replaces legacy errorMessage validation with validators; adjusts update() logic. |
| meshroom/aliceVision/LdrToHdrMerge.py | Replaces legacy errorMessage validation with validators; adjusts update() logic. |
| meshroom/aliceVision/LdrToHdrCalibration.py | Replaces legacy errorMessage validation with validators; adjusts update() logic. |
| meshroom/aliceVision/KeyframeSelection.py | Migrates outputExtension validation from validValue/errorMessage to validators. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicolas-lambert-tc
force-pushed
the
feature/node-valididy-check
branch
from
17cd0d7 to
d6ecc4f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the new validation paradigm and remove the validValue/errorMessages attributes.
meshroom related PR