Miscellaneous memory correctness improvements#2103
Open
SFN-eu wants to merge 2 commits intoalicevision:developfrom
Open
Miscellaneous memory correctness improvements#2103SFN-eu wants to merge 2 commits intoalicevision:developfrom
SFN-eu wants to merge 2 commits intoalicevision:developfrom
Conversation
SFN-eu
force-pushed
the
dev/fix-misc-memory-issues
branch
from
75e3758 to
7b08db0
Compare
Contributor
|
The first commit related to shared_ptr is not correct. There is no reason to enforce the use of shared_ptr or use_count. |
SFN-eu
force-pushed
the
dev/fix-misc-memory-issues
branch
from
7b08db0 to
40375f0
Compare
Author
|
Removed |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanup of some memory correctness issues I ran into while working on #2077
Features list
Implementation remarks
I tried to keep changes to a minimum.
Each step in the Features List is it’s own commit, so it can be cherry picked as desired.