Adding new node for triangulation for new pipelines#2113
Merged
servantftransperfect merged 2 commits intodevelopfrom Apr 30, 2026
Merged
Adding new node for triangulation for new pipelines#2113servantftransperfect merged 2 commits intodevelopfrom
servantftransperfect merged 2 commits intodevelopfrom
Conversation
servantftransperfect
force-pushed
the
dev/triangulation
branch
from
e9e7cfd to
2663645
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
servantftransperfect
force-pushed
the
dev/triangulation
branch
from
2663645 to
d1b58a9
Compare
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new “SfM triangulation from existing poses + tracks” entrypoint to the AliceVision pipeline (CLI + Meshroom node) and tightens SfMData merge behavior by detecting duplicate pose IDs during simple merges.
Changes:
- Added a new pipeline executable
aliceVision_sfmTriangulatingto triangulate landmarks from an input SfMData + tracks file. - Integrated the new executable into the pipeline CMake build and exposed it via a new Meshroom node
SfMTriangulating. - Improved
sfmMergesimple merge to detect duplicate pose IDs (with optional duplicate ignoring).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/software/utils/main_sfmMerge.cpp | Adds pose merging with duplicate-ID detection in simpleMerge; minor cleanup in fromLandmarksMerge. |
| src/software/pipeline/main_sfmTriangulating.cpp | New CLI tool to triangulate landmarks from tracks using existing camera poses. |
| src/software/pipeline/CMakeLists.txt | Builds and links the new aliceVision_sfmTriangulating executable. |
| meshroom/aliceVision/SfMTriangulating.py | New Meshroom node wrapping the new triangulation CLI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
servantftransperfect
force-pushed
the
dev/triangulation
branch
from
d1b58a9 to
2affc8e
Compare
servantftransperfect
force-pushed
the
dev/triangulation
branch
from
2affc8e to
89f83d9
Compare
|
CedricThebault
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new SfM Triangulation feature to the AliceVision pipeline. It adds a new command-line tool for triangulating keypoints using existing camera poses, updates the build system to include this tool, and provides a corresponding Meshroom node for integration into workflows. Additionally, it improves the merging logic for SfMData poses to handle duplicates more robustly.
New SfM Triangulation Feature:
aliceVision_sfmTriangulatingfor triangulating keypoints based on existing camera poses, including argument parsing, triangulation logic, and output handling.SfMTriangulatinginSfMTriangulating.pyto expose the triangulation functionality to the Meshroom GUI, with configurable parameters for triangulation.Improvements to SfMData Merging:
simpleMergefunction to merge pose data from two SfMData objects, checking for duplicate pose IDs and reporting errors if duplicates are found and not ignored.