Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the send latency calculation where the default send latency value was being incorrectly multiplied by 1000. The PR description states that send_lat is already in nanoseconds on the default path and should not be multiplied.
Changes:
- Moved the multiplication by 1000 to only occur when the AS_SEND_LAT environment variable is set (converting from microseconds to nanoseconds)
- Removed the unconditional multiplication that was incorrectly applied to both the default value and environment variable values
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| send_lat = 1000 * std::stoi(send_lat_env); | ||
| } catch (const std::invalid_argument& e) { | ||
| NcclLog->writeLog(NcclLogLevel::ERROR,"send_lat set error"); | ||
| exit(-1); |
There was a problem hiding this comment.
The exception handling for std::stoi only catches std::invalid_argument but not std::out_of_range, which can also be thrown when the converted value would fall out of the range of int. Consider catching both exceptions or using a catch-all for std::exception to handle both cases consistently.
Suggested change
| exit(-1); | |
| exit(-1); | |
| } catch (const std::out_of_range& e) { | |
| NcclLog->writeLog(NcclLogLevel::ERROR,"send_lat set error"); | |
| exit(-1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not multiply
send_latby 1000 on default path as it's already ns there.