Open
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Pipeline Parallelism (PP) size was hardcoded to 1, causing incorrect Data Parallelism (DP) group construction. The fix properly reads the PP size from the workload configuration, which ensures correct collective operations and eliminates unnecessary communication traffic.
Changes:
- Replaced hardcoded
PP_size = 1with conditional logic that reads fromworkload->pipeline_model_parallelism - Applied the fix consistently to both
mock_nccl_grobal_group_initandmock_nccl_comms_initfunctions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a hardcoded PP size that caused incorrect DP group construction, which in turn produced wrong collectives and extra communication traffic. With the proper PP value, DP groups are formed per stage and collective operations reflect the intended topology.