Skip to content

Comments

addd safary tracking#145

Open
srt0422 wants to merge 1 commit intomainfrom
improvement-safary-tracking
Open

addd safary tracking#145
srt0422 wants to merge 1 commit intomainfrom
improvement-safary-tracking

Conversation

@srt0422
Copy link

@srt0422 srt0422 commented Feb 5, 2026

No description provided.

@netlify
Copy link

netlify bot commented Feb 5, 2026

Deploy Preview for alloradocs ready!

Name Link
🔨 Latest commit 6f9f525
🔍 Latest deploy log https://app.netlify.com/projects/alloradocs/deploys/6983e720b46db800084e5ccd
😎 Deploy Preview https://deploy-preview-145--alloradocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Author

@srt0422 srt0422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review — PASS ✅

Clean implementation. Uses next/script with strategy="afterInteractive" correctly. Has SRI integrity hash. 10 lines.

Copy link
Author

@srt0422 srt0422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: clean. Single file changed (theme.config.tsx) adding Safary SDK tracking script.

Changes: Adds Safary analytics SDK (v0.1.19) via Next.js Script component with afterInteractive strategy.

Security assessment:

  • ✅ Script loaded from tag.safary.club — official Safary domain (legitimate web3 analytics platform)
  • ✅ Subresource Integrity (SRI) hash present (sha256-HIiAIcXc6BMTZX//tyipuAVyCNCB67w86gVFLK52pxY=)
  • crossOrigin="anonymous" set correctly for SRI
  • afterInteractive strategy — won't block page load
  • ✅ No inline scripts, no eval, no PII collection concerns

LGTM 👍 — would approve but can't approve own PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant