Conversation
Shallow clones can't resolve a specific SHA — only branches/tags.
Remove hardcoded $IDASDK/src/bin from RPATH — it can resolve to stub dylibs instead of real runtime libraries, causing symbol failures when opening databases. Now uses only @executable_path/ (macOS) and $ORIGIN (Linux), matching the SDK's own idalib makefile. The binary deploys to IDABIN via RUNTIME_OUTPUT_DIRECTORY, so the paths resolve correctly. Closes #21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GIT_SHALLOW TRUEfrom fastmcpp FetchContent — shallow clones can't resolve pinned commit SHAs@executable_path//$ORIGINonly, matching the SDK's GNU make convention. Removes hardcoded$IDASDK/src/binwhich could resolve to stub dylibs instead of real runtime librariesCloses #21
Test plan
cmake --build build/cli --target idasql_cli -j8otool -l $IDABIN/idasql | grep -A2 LC_RPATHshows only@executable_path/