Skip to content

add "hollywood" and "nyancat" packages #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yougamepaster wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add "hollywood" and "nyancat" packages #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ansible/roles/packages/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ fun_packages:
- nethack-console
- tty-clock
- bastet
- hollywood
- nyancat
Comment on lines +229 to +230
Copy link

@gemini-code-assist gemini-code-assist bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The nyancat package is already present in this list on line 224, which makes this addition a duplicate. Please only add the new hollywood package.

For future reference, to improve maintainability, it's good practice to keep lists like this sorted alphabetically.

  - hollywood

Comment on lines +229 to +230
Copy link

@coderabbitai coderabbitai bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Run this on each supported distro/codename image (e.g., ubuntu/debian variants).
for pkg in hollywood nyancat; do
  echo "Checking package: $pkg"
  if apt-cache show "$pkg" >/dev/null 2>&1; then
    echo "  -> available"
  else
    echo "  -> NOT available (would fail apt task)"
  fi
done

Repository: allthingslinux/atl.sh

Length of output: 200

Do not add hollywood and remove duplicate nyancat—both packages are unavailable in the apt repository.

The verification confirms neither hollywood nor nyancat are available in the apt repository. Line 230 re-adds nyancat, which is already at line 224, creating a duplicate. Adding hollywood will cause the unconditional ansible.builtin.apt task to fail. Remove line 230 entirely and investigate why nyancat remains on the list at line 224 if it is not available in supported distributions.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@ansible/roles/packages/defaults/main.yml` around lines 229 - 230, Remove the
unavailable package entries from the default packages list: delete the
'hollywood' entry and remove the duplicated 'nyancat' entry so each package
appears only once; update the YAML in ansible/roles/packages/defaults/main.yml
where the default packages list is declared (the list consumed by the
ansible.builtin.apt task) and verify the remaining 'nyancat' at the earlier
occurrence is intentionally included for supported distros or remove it there
instead if not supported.

Copy link

@cubic-dev-ai cubic-dev-ai bot Mar 25, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Duplicate nyancat entry in fun_packages list adds redundant package install operations.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At ansible/roles/packages/defaults/main.yml, line 230:

<comment>Duplicate `nyancat` entry in `fun_packages` list adds redundant package install operations.</comment>

<file context>
@@ -226,6 +226,8 @@ fun_packages:
   - tty-clock
   - bastet
+  - hollywood
+  - nyancat
 
 # ──────────────────────────────────────────────
</file context>
Fix with Cubic


# ──────────────────────────────────────────────
# System tools (admin)
Expand Down