Skip to content

Fix ignoring of events when compositing (e.g. japanese) chars #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
almarklein merged 1 commit into from
Feb 2, 2026
Merged

Fix ignoring of events when compositing (e.g. japanese) chars #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions timetagger/app/dialogs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1863,11 +1863,11 @@ def close(self, e=None):

def _on_key(self, e):
key = e.key.lower()
if self._autocompleter.on_key(e):
if self._is_composing:
pass
elif self._autocompleter.on_key(e):
e.stopPropagation()
return
elif self._is_composing:
pass
elif key == "enter" or key == "return":
self.submit_soon()
else:
Expand Down Expand Up @@ -2456,7 +2456,7 @@ def _on_key2(self, e):
key = e.key.lower()
if self._is_composing:
pass
if key == "enter" or key == "return":
elif key == "enter" or key == "return":
e.stopPropagation()
e.preventDefault()
self._on_name2_done()
Expand Down Expand Up @@ -2691,11 +2691,11 @@ def _check_names(self):

def _on_key(self, e):
key = e.key.lower()
if self._autocompleter.on_key(e):
if self._is_composing:
pass
elif self._autocompleter.on_key(e):
e.stopPropagation()
return
elif self._is_composing:
pass
elif key == "enter" or key == "return":
e.stopPropagation()
e.preventDefault()
Expand Down