Refill Ghostty prewarm pool after consumption#187
Merged
almogdepaz merged 3 commits intoJul 20, 2026
Merged
Conversation
Owner
Author
|
reviewed the PR #187 diff. no blocking findings. findings:
nonblocking observations:
|
Owner
Author
|
addressed the low/nonblocking refill error-handling finding in
verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
take()as a pure consume operation so refill does not start wasm work in the terminal-open stackperf-*sessions interminal-load-perf.tsso repeated measurements do not exhaust broker fdsVerification
bun run typecheckbun test tests/unit/ghostty-prewarm-pool.test.ts tests/unit/ghostty-prewarm-debug.test.tsbun test tests/unit/terminal-load-perf.test.ts tests/unit/ghostty-prewarm-pool.test.ts tests/unit/ghostty-prewarm-debug.test.tsbunx playwright test tests/e2e/grid.e2e.ts --project=desktop--broker=noStacked on #186 (
prewarm-ghostty-immediately). Retarget/rebase tomainafter #186 merges.