Polish grid loading UX and perf runs#189
Merged
Merged
Conversation
almogdepaz
force-pushed
the
ui-perf-followups
branch
from
July 20, 2026 23:00
eef92c8 to
7c4b3f7
Compare
Owner
Author
|
subagent review: clean. checked PR #189 against main for terminal loading css/copy, perf harness WOLFPACK_PERF_RUNS aggregation/cleanup, generated assets, and attach/reveal timing risk. no correctness/regression findings; no socket/hydration/reveal sequencing changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
take control to view,opened elsewhere)WOLFPACK_PERF_RUNSsupport plus aggregate perf summary output and per-run session cleanupVerification
bun test tests/unit/terminal-loading-css.test.ts tests/unit/terminal-loading-ui.test.ts tests/unit/terminal-load-perf.test.tsbun run typecheckWOLFPACK_PERF_RUNS=2 WOLFPACK_PERF_PAGE_LOAD_WAIT_MS=0 WOLFPACK_PERF_GRID_CELLS=2 ... bun run scripts/terminal-load-perf.tsperf-*sessions = 0--broker=noloading terminallabel, no console errors/failed requestsbunx playwright test tests/e2e/grid.e2e.ts --project=desktop— 21 passedGIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false bun test— 1818 passedNote: raw
bun testin this local shell hit a 1Password git signing failure in a child test repo; disabling commit signing via env verified the suite.