Add laptop search script for IVORY and KSP (i5+, 16GB+, 512GB+, ≤3000₪, no-OS)#21
Draft
Add laptop search script for IVORY and KSP (i5+, 16GB+, 512GB+, ≤3000₪, no-OS)#21
Conversation
Agent-Logs-Url: https://github.com/alonitac/DevOpsMay22/sessions/cf6e9b5f-8312-434f-a3a3-cffa32028ef3 Co-authored-by: DeniZaychenko <91252016+DeniZaychenko@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Search for laptops without pre-installed OS
Add laptop search script for IVORY and KSP (i5+, 16GB+, 512GB+, ≤3000₪, no-OS)
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a Python web scraper targeting the Israeli retailers IVORY and KSP, filtering laptop listings by: Intel Core i5+ / AMD Ryzen 5+ CPU, ≥16 GB RAM, ≥512 GB SSD, price ≤3,000 NIS, and no pre-installed Windows (FreeDOS / no OS / Linux all accepted).
New files —
19_laptop_search/laptop_search.py— queries KSP and IVORY JSON catalog APIs, applies all filters, prints results sorted by price. Network errors are caught per-source and reported to stderr without aborting the other source.requirements.txt—requests,beautifulsoup4,lxmltest_laptop_search.py— 34 unit tests covering each filter helper andmatches_criteriaKey filtering logic
RAM vs SSD disambiguation — naively matching any
NGBvalue would flag the 512 GB SSD as passing the 16 GB RAM check. The fix: require explicit memory keywords (DDR, LPDDR, RAM) first; fall back to bareNGBonly for values in the typical RAM range (16–128 GB):OS filter — rejects anything containing
windows; accepts Hebrewללא מערכת הפעלה,FreeDOS,Linux,DOS, andNo OS.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ksp.co.il/usr/bin/python python laptop_search.py(dns block)www.ivory.co.il/usr/bin/python python laptop_search.py(dns block)If you need me to access, download, or install something from one of these locations, you can either:
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.