Skip to content

fix: Add onClick parameter to SettingsTileScaffold and use it in SettingsMenuLink #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alorma merged 2 commits into from
Mar 5, 2026
Merged

fix: Add onClick parameter to SettingsTileScaffold and use it in SettingsMenuLink #489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88ee38
feat: Add `onClick` parameter to `SettingsTileScaffold` and use it in…
maicol07 Mar 5, 2026
900e940
refactor: Remove unused import for clickable from SettingsMenuLink
maicol07 Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ...ssive/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsMenuLink.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
package com.alorma.compose.settings.ui.expressive

import androidx.compose.foundation.clickable
import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi
import androidx.compose.material3.ListItemColors
import androidx.compose.material3.ListItemElevation
Expand Down Expand Up @@ -29,12 +28,10 @@ fun SettingsMenuLink(
SettingsTileScaffold(
modifier =
Modifier
.clickable(
enabled = enabled,
onClick = onClick,
).semantics(properties = semanticProperties)
.semantics(properties = semanticProperties)
.then(modifier),
enabled = enabled,
onClick = onClick,
title = title,
supportingContent = subtitle,
leadingContent = icon,
Expand Down
3 changes: 2 additions & 1 deletion ...e/src/commonMain/kotlin/com/alorma/compose/settings/ui/expressive/SettingsTileScaffold.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ fun SettingsTileScaffold(
title: @Composable () -> Unit,
modifier: Modifier = Modifier,
enabled: Boolean = true,
onClick: () -> Unit = {},
supportingContent: @Composable (() -> Unit)? = null,
leadingContent: @Composable (() -> Unit)? = null,
colors: ListItemColors = SettingsTileDefaults.colors(),
Expand All @@ -24,7 +25,7 @@ fun SettingsTileScaffold(
) {
SegmentedListItem(
selected = false,
onClick = {},
onClick = onClick,
shapes = shapes,
modifier = Modifier.fillMaxWidth().then(modifier),
enabled = enabled,
Expand Down
Loading