Fix small windows incorrectly auto-maximized in seamless mode#2
Open
MajidNajafi wants to merge 1 commit into
Open
Fix small windows incorrectly auto-maximized in seamless mode#2MajidNajafi wants to merge 1 commit into
MajidNajafi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In seamless mode, the first window is always auto-maximized to fill the viewport regardless of its size. This is most visible with RDP applications where a small login dialog (username/password prompt) gets stretched to fullscreen instead of appearing at its natural size.
Root Cause
The handleNewWindow auto-maximize heuristic for the first window in seamless mode (
!hasDesktop && windowCount === 0) does not consider the window's original dimensions. Any first window that isn't explicitly a popup/dialog/terminal type gets maximized, even if it's a small form or dialog with a NORMAL window type.Fix
Added a size guard to the auto-maximize condition: the window's server-requested dimensions must be at least 60% of the desktop in both width and height. Small windows now keep their natural size and get centered on screen. Desktop and shadow modes are unaffected (they never hit this code path).