Preprocessing#337
Draft
mschmutzhart wants to merge 63 commits intomasterfrom
Draft
Conversation
…al in InternalRule
…al in InternalRule
# Conflicts: # alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/grounder/NaiveGrounder.java # alpha-core/src/main/java/at/ac/tuwien/kr/alpha/core/programs/transformation/SimplePreprocessing.java
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #337 +/- ##
============================================
+ Coverage 70.23% 71.01% +0.78%
- Complexity 2123 2192 +69
============================================
Files 182 183 +1
Lines 8023 8132 +109
Branches 1423 1455 +32
============================================
+ Hits 5635 5775 +140
+ Misses 2028 1976 -52
- Partials 360 381 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| * Gebser, M., Kaufmann, B., Neumann, A., & Schaub, T. (2008, June). Advanced Preprocessing for Answer Set Solving. | ||
| * In ECAI (Vol. 178, pp. 15-19). | ||
| */ | ||
|
|
| * solvers, as seen in: | ||
| * Gebser, M., Kaufmann, B., Neumann, A., & Schaub, T. (2008, June). Advanced Preprocessing for Answer Set Solving. | ||
| * In ECAI (Vol. 178, pp. 15-19). | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| */ | |
| * @see <a href="https://doi.org/10.3233/978-1-58603-891-5-15">doi:10.3233/978-1-58603-891-5-15</a> | |
| */ |
Collaborator
Author
There was a problem hiding this comment.
Thanks for the suggestion, I changed the reference to the link.
| * Returns a copy of the rule with the specified literal removed, or null if the new rule would have an empty body. | ||
| * @return the rule without the specified literal, null if no body remains. | ||
| */ | ||
| public InternalRule returnCopyWithoutLiteral(Literal literal) { |
Member
There was a problem hiding this comment.
Is there a particular reason to stress "return" here?
Suggested change
| public InternalRule returnCopyWithoutLiteral(Literal literal) { | |
| public InternalRule copyWithoutLiteral(Literal literal) { |
Collaborator
Author
There was a problem hiding this comment.
No real reason, so it could be changed. But more importantly this is one of a few changes that I meant to revert but overlooked. Now this method is implemented within the SimplePreprocessing class.
I have now looked over all changed files and hopefully removed all unnecessary changes.
* doc: Add ConfWS21 paper to README Co-authored-by: Richard Taupe <richard.taupe@siemens.com>
… of interval term
Link to "A coder's guide to answer set programming" from README.md
Fix SimpleLogger time format
Improve logging output for debugging.
…al in InternalRule
…al in InternalRule
…to preprocessing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the preprocessing techniques suggested in #114 .
So far only elementary simplifications have been added as a program transformation, with a command line option to disable them (dpp).
The viability of more sophisticated simplifications, using equivalence classes, in a lazy grounding setting is still being explored.