Check agreeement_signed as well as agreeement_signed_by_id#6000
Open
whpearson wants to merge 1 commit into
Open
Check agreeement_signed as well as agreeement_signed_by_id#6000whpearson wants to merge 1 commit into
whpearson wants to merge 1 commit into
Conversation
If we don't do something like this we can get into a bad state. This is where they have signed the agreement and then someone sets them not to have signed the agreement (due to a change of government or similar) This sets agreement_signed to false but leaves agreement_signed_by_id, so it shows up in the UI as signed but still doesn't actually allow them to go live. This fixes that bug.
whpearson
force-pushed
the
fix_inconsistent_data_agreement
branch
from
July 20, 2026 11:02
db0b2ea to
ade342a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we don't do something like this we can get into a bad state.
This is where they have signed the agreement and then someone sets them not to have signed the agreement (due to a change of government or similar)
This sets agreement_signed to false but leaves agreement_signed_by_id, so it shows up in the UI as signed but still doesn't actually allow them to go live.