-
-
Notifications
You must be signed in to change notification settings - Fork 30
Fabric 1.21.10 support + Mojang mappings migration (AI made) #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Darker935
wants to merge
15
commits into
alphaqu:main
Choose a base branch
from
Darker935:fabric-1.21.10
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
3adb789
Initial plan
Copilot bfb88ea
Add source files from fabric-1.21.4 branch
Copilot 405b097
Migrate source from YARN 1.21.4 to Mojang mappings for MC 1.21.10
Copilot 5f5c191
Fix modmenu version to 16.0.0-rc.1 for Minecraft 1.21.10
Copilot 03254f0
Fix Mojang class names: SpriteIdentifier→Material, BakedModelManager→…
Copilot bdc7167
Fix build: downgrade loom_version from 1.14-SNAPSHOT to 1.11-SNAPSHOT…
Copilot a55366b
Fix Gradle wrapper to 9.3.0 and loom_version to 1.15-SNAPSHOT
Copilot 852f501
Fix YARN → Mojang class mapping compilation errors for 1.21.10
Copilot aa65515
Fix Gradle distribution URL to include the correct version 9.3.0
Darker935 a890c25
Fix YARN→Mojang mapping issues: shader classes, Dazy subclasses, Affi…
Copilot fdfa330
Fix Modrinth plugin version, add CI build workflow
Copilot 3fb181e
Fix Gradle 9 build error: move sourceCompatibility into java {} block
Copilot ce5d76f
Fix Gradle 9 error: replace archivesBaseName with base.archivesName
Copilot 5272b22
Updated for 1.21.10 (AI made)
Darker935 2b266db
Merge branch 'copilot/adapt-mod-for-latest-versions' of https://githu…
Darker935 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # | ||
| # https://help.github.com/articles/dealing-with-line-endings/ | ||
| # | ||
| # These are explicitly windows files and should use crlf | ||
| *.bat text eol=crlf | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: Launching Issue | ||
| description: Create an issue about your game failing to load/cache | ||
| title: "[LAUNCH]: " | ||
| labels: ["type: bug", "status: idle"] | ||
| body: | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Thank you for reporting an issue about DashLoader, we care a lot about our mod and enjoy fixing every bug. | ||
| - type: input | ||
| id: version | ||
| attributes: | ||
| label: Version | ||
| description: What version of DashLoader are you running? | ||
| placeholder: 5.0.0-alpha.3 | ||
| validations: | ||
| required: true | ||
| - type: input | ||
| id: mc-version | ||
| attributes: | ||
| label: Minecraft Version | ||
| description: What Minecraft version are you using? | ||
| placeholder: 1.19.3 | ||
| validations: | ||
| required: true | ||
| - type: markdown | ||
| attributes: | ||
| value: | | ||
| Please provide **THE ENTIRE LOG** as the crashlogs don't contain much information about DashLoader. | ||
| Use a website like https://mclo.gs/ to upload logs. | ||
| Preferably we want a log for when you create the cache (The popup at the top left is present) and another log for when DashLoader loads the cache. | ||
| - type: input | ||
| id: logs | ||
| attributes: | ||
| label: Entire Logs | ||
| description: Link to the logs. | ||
| placeholder: https://mclo.gs/5K0ChKa | ||
| validations: | ||
| required: true | ||
| - type: textarea | ||
| id: extra | ||
| attributes: | ||
| label: Additional Notes | ||
| description: Anything else you want to add? | ||
| validations: | ||
| required: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ "main", "copilot/**" ] | ||
| pull_request: | ||
| branches: [ "main" ] | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Java 21 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '21' | ||
| distribution: 'temurin' | ||
|
|
||
| - name: Setup Gradle | ||
| uses: gradle/actions/setup-gradle@v4 | ||
|
|
||
| - name: Build with Gradle | ||
| run: ./gradlew build --no-daemon | ||
|
|
||
| - name: Upload build artifacts | ||
| uses: actions/upload-artifact@v4 | ||
| if: success() | ||
| with: | ||
| name: build-artifacts | ||
| path: build/libs/*.jar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,4 +31,5 @@ bin/ | |
|
|
||
| # Ignore Gradle build output directory | ||
| build | ||
| /run/ | ||
| run/ | ||
| upload.sh | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,50 @@ | ||
| # DashLoader-Definition | ||
| Launch Minecraft at the speed of light. | ||
|
|
||
| All of the source code is present in version dependant branches. | ||
|
|
||
| For the core framework go to https://github.com/QuantumFusionMC/DashLoader-Core | ||
|
|
||
|  | ||
| DashLoader's performance is highly aided by the [YourKit Java Profiler](https://www.curseforge.com/linkout?remoteUrl=https%253a%252f%252fwww.yourkit.com%252fjava%252fprofiler%252f) which helps us greatly with keeping standards high and load times low. | ||
| # DashLoader Github | ||
| Welcome to the codebase where DashLoader lives! Please report any issues you find with DashLoader here. | ||
| <center> | ||
| <p align="center" style="font-family: sans-serif, tahoma, arial, helvetica; font-size: 18px;"> | ||
| <!-- Features --> | ||
| <img src="https://notalpha.dev/assets/dashloader/features-new.png" alt="Description" width="1000"/> | ||
| <br/> | ||
| This mod accelerates the Minecraft Asset Loading system by caching all of its content, This leads to a much faster | ||
| game load. | ||
| It does this by caching all of its content on first launch and on next launch loading back that exact cache. | ||
| The cache loading is hyper fast and scalable which utilises your entire system. | ||
| <br/><br/><br/> | ||
| <strong>Important notes:</strong> | ||
| <!-- Cache slowdown explanation --> | ||
| <br/><br/> • The first time your launch DashLoader it will be <strong>significantly slower</strong>. | ||
| Because it needs to create a cache which contains all the assets minecraft normally loads. | ||
| This will also happen every time you change a mod/resourcepack if that configuration does not have an existing | ||
| cache. | ||
| <!-- Mod compatibility --> | ||
| <br/><br/> • DashLoader has been known to be incompatible with a lot of mods. | ||
| DashLoader 3.0 has massively improved compatibility by not forcing mod developers to add explicit support to make | ||
| their assets cachable. | ||
| This means that DashLoader will load assets normally for mod assets that cannot be cached. | ||
| While this improves mod compatibility it hurts speed as the minecraft loading system is quite slow. | ||
| <!-- Artists --> | ||
| <br/><br/> • If you use DashLoader for Developing mods or creating resource packs you can press | ||
| <code>f3 + t</code> to recreate the cache to load your new assets in. | ||
| If you want to just show off the speed of DashLoader you can press <code>shift + f3 + t</code> | ||
| <br/><br/><br/> | ||
| <!-- Community .--> | ||
| <img src="https://notalpha.dev/assets/dashloader/community-new.png" alt="Community" width="1000"/> | ||
| <br/> | ||
| <img src="https://i.imgur.com/qbysL1T.png" alt="Discord" width="500"/> | ||
| <!-- Sponsors --> | ||
| <img src="https://notalpha.dev/assets/dashloader/sponsors-new.png" alt="Sponsors" width="1000"/> | ||
| <br/> | ||
| <a href="https://www.yourkit.com/java/profiler/">YourKit</a> | ||
| Makes amazing profilers for both Java and .NET. | ||
| We use their Java Profiler to understand where to optimize further and make DashLoader faster. | ||
| <br/> | ||
| <a href="https://www.jetbrains.com/">JetBrains</a> | ||
| Creates excellent IDEs for all programmers and have provided us with access to their enterprise products for use to | ||
| develop DashLoader and Hyphen. | ||
| <!-- Donate --> | ||
| <img src="https://notalpha.dev/assets/dashloader/donate-new.png" alt="Donate" width="1000"/> | ||
| <br/> | ||
| I have a <a href="https://ko-fi.com/notequalalpha">Ko-Fi page</a> if you would like to Support me. <br/> | ||
| Please only support me if you like what I do, and you are not in a bad financial situation to do so. | ||
| </p> | ||
| </center> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,184 @@ | ||
| plugins { | ||
| // Publishing | ||
| id 'com.matthewprenger.cursegradle' version '1.4.0' apply false | ||
| id "com.modrinth.minotaur" version "2.8.10" apply false | ||
|
|
||
| id 'fabric-loom' version "${loom_version}" | ||
| id 'maven-publish' | ||
| } | ||
|
|
||
| def enablePublishing = providers.gradleProperty("enablePublishing") | ||
| .map { it.toBoolean() } | ||
| .getOrElse(false) | ||
|
|
||
| if (enablePublishing) { | ||
| apply plugin: "com.modrinth.minotaur" | ||
| apply plugin: "com.matthewprenger.cursegradle" | ||
| } | ||
|
|
||
| base { | ||
| archivesName = project.archives_base_name | ||
| } | ||
| version = project.mod_version | ||
| group = project.maven_group | ||
|
|
||
| repositories { | ||
| mavenCentral() | ||
| mavenLocal() | ||
| maven { | ||
| url 'https://jitpack.io' | ||
| } | ||
| maven { | ||
| url "https://notalpha.dev/maven/releases" | ||
| } | ||
| maven { | ||
| name = "Terraformers" | ||
| url = "https://maven.terraformersmc.com/" | ||
| } | ||
| maven { | ||
| name = "Nucleoid" | ||
| url = "https://maven.nucleoid.xyz/" | ||
| } | ||
| } | ||
|
|
||
| loom { | ||
| accessWidenerPath = file("src/main/resources/dashloader.accesswidener") | ||
| log4jConfigs.from(file("log4j-dev.xml")) | ||
| } | ||
|
|
||
| dependencies { | ||
| // To change the versions see the gradle.properties file | ||
| minecraft "com.mojang:minecraft:${project.minecraft_version}" | ||
| mappings loom.officialMojangMappings() | ||
| modImplementation "net.fabricmc:fabric-loader:${project.loader_version}" | ||
|
|
||
| modImplementation "com.terraformersmc:modmenu:${project.modmenu_version}" | ||
|
|
||
| implementation "dev.notalpha:Hyphen:0.4.0-rc.5" | ||
| include "dev.notalpha:Hyphen:0.4.0-rc.5" | ||
|
|
||
| implementation "dev.notalpha:Taski:2.1.0" | ||
| include "dev.notalpha:Taski:2.1.0" | ||
|
|
||
| implementation 'com.github.luben:zstd-jni:1.5.7-1' | ||
| include 'com.github.luben:zstd-jni:1.5.7-1' | ||
|
|
||
| modCompileOnly fabricApi.module("fabric-renderer-indigo", project.fabric_version) | ||
|
|
||
| // For Modmenu | ||
| modRuntimeOnly fabricApi.module("fabric-api-base", project.fabric_version) | ||
| modRuntimeOnly fabricApi.module("fabric-key-binding-api-v1", project.fabric_version) | ||
| modRuntimeOnly fabricApi.module("fabric-lifecycle-events-v1", project.fabric_version) | ||
| modRuntimeOnly fabricApi.module("fabric-resource-loader-v0", project.fabric_version) | ||
| modRuntimeOnly fabricApi.module("fabric-screen-api-v1", project.fabric_version) | ||
| } | ||
|
|
||
| test { | ||
| useJUnitPlatform() | ||
| testLogging { | ||
| events "passed", "skipped", "failed" | ||
| } | ||
| } | ||
|
|
||
| processResources { | ||
| inputs.property "version", project.version | ||
|
|
||
| filesMatching("fabric.mod.json") { | ||
| expand "version": project.version | ||
| } | ||
| } | ||
|
|
||
| tasks.withType(JavaCompile).configureEach { | ||
| // ensure that the encoding is set to UTF-8, no matter what the system default is | ||
| // this fixes some edge cases with special characters not displaying correctly | ||
| // see http://yodaconditions.net/blog/fix-for-java-file-encoding-problems-with-gradle.html | ||
| // If Javadoc is generated, this must be specified in that task too. | ||
| it.options.encoding = "UTF-8" | ||
|
|
||
| // Minecraft 1.17 (21w19a) upwards uses Java 16. | ||
| it.options.release = 21 | ||
| } | ||
|
|
||
| java { | ||
| sourceCompatibility = JavaVersion.VERSION_21 | ||
| targetCompatibility = JavaVersion.VERSION_21 | ||
| //include sources in maven publish | ||
| withSourcesJar() | ||
| } | ||
|
|
||
| jar { | ||
| from("LICENSE") { | ||
| rename { "${it}_${project.base.archivesName}" } | ||
| rename { "${it}_${project.base.archivesName}" } | ||
| } | ||
| } | ||
|
|
||
| // Publishing | ||
| if (enablePublishing) { | ||
| modrinth { | ||
| token = project.hasProperty("modrinthApiKey") ? project.modrinthApiKey : "" | ||
| projectId = 'ZfQ3kTvR' | ||
| changelog = file("changelog.md").getText() | ||
| versionNumber = project.version | ||
| versionName = "$project.version".split("\\+")[0] + " for $project.minecraft_version" | ||
| uploadFile = remapJar | ||
| versionType = "beta" | ||
| gameVersions = ['1.21.10'] | ||
| loaders = ['fabric', 'quilt'] | ||
| } | ||
|
|
||
| curseforge { | ||
| apiKey = project.hasProperty("curseForgeApiKey") ? project.curseForgeApiKey : "" | ||
| project { | ||
| id = '472772' | ||
| changelogType = "markdown" | ||
| changelog = file("changelog.md") | ||
| releaseType = 'beta' | ||
|
|
||
| addGameVersion "1.21.10" | ||
| addGameVersion "Fabric" | ||
| addGameVersion "Quilt" | ||
| addGameVersion "Java 21" | ||
|
|
||
| mainArtifact(remapJar) { | ||
| displayName = "$project.version".split("\\+")[0] + " for $project.minecraft_version" | ||
| } | ||
| } | ||
| options { | ||
| forgeGradleIntegration = false | ||
| } | ||
| } | ||
|
|
||
| tasks.register("publishMod") { | ||
| dependsOn 'modrinth' | ||
| dependsOn 'curseforge' | ||
| } | ||
| } else { | ||
| tasks.register("publishMod") { | ||
| doLast { | ||
| logger.lifecycle("Publishing disabled. Re-run with -PenablePublishing=true to publish.") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| tasks.register("getVersion") { | ||
| print("$project.version") | ||
| } | ||
|
|
||
| publishing { | ||
| repositories { | ||
| maven { | ||
| name = "notalpha" | ||
| url = "https://notalpha.dev/maven/releases" | ||
| credentials(PasswordCredentials) | ||
| authentication { | ||
| basic(BasicAuthentication) | ||
| } | ||
| } | ||
| } | ||
| publications { | ||
| maven(MavenPublication) { | ||
| from components.java | ||
| } | ||
| } | ||
| } |
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
bug_report.mdtemplate has been changed to remove DashLoader-specific context fields (DashLoader version, Minecraft version, mods list, full crash log). The new template is generic (GitHub default), which removes important information that would be needed to triage DashLoader-specific issues — specifically, the crash log request has been removed entirely, which is critical for debugging this mod. The PR description does not mention this as an intentional change.