Skip to content

feat(gc): add RPCs for approving and listing pending commitment plan approvals #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iamnikai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(gc): add RPCs for approving and listing pending commitment plan approvals #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions gc/v1/gc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,20 @@ service GuaranteedCommitments {
};
}

// WORK-IN-PROGRESS: Approves or rejects a pending commitment purchase plan application.
rpc ApproveCommitmentPlanApply(ApproveCommitmentPlanApplyRequest) returns (CommitmentPlanDetails) {
option (google.api.http) = {
post: "/v1/commitments/plans/{planId}/approve"
body: "*"
};
}

// WORK-IN-PROGRESS: Lists all pending commitment plan approvals.
rpc ListPendingCommitmentPlanApprovals(ListPendingCommitmentPlanApprovalsRequest) returns (ListPendingCommitmentPlanApprovalsResponse) {
option (google.api.http) = {
get: "/v1/commitments/plans/approvals"
};
}
// ####################### COMMITMENTS #######################

// WORK-IN-PROGRESS: Retrieves a list of commitments.
Expand Down Expand Up @@ -536,6 +550,15 @@ message CreateGuaranteedCommitmentAccessRequest {
string externalId = 2;
}

message ApproveCommitmentPlanApplyRequest {
string planId = 1;
// true = approve, false = reject
bool approved = 2;
// optional reason if rejected
string reason = 3;
}

message ListPendingCommitmentPlanApprovalsRequest {}

// ####################### RESPONSE MESSAGES #######################

Expand Down Expand Up @@ -1242,4 +1265,20 @@ message GetPurchasePlansDetailsResponse {

// Audit history of the plan
repeated PlanHistoryEntry history = 4;
}

message PendingCommitmentPlanApproval {
string planId = 1;
string companyId = 2;
string userId = 3;
string planName = 4;
string status = 5; // "PENDING_APPROVAL" | "APPROVED" | "REJECTED"
string requestedAt = 6;
double monthlySavings = 7;
double totalSavings = 8;
double monthlyCost = 9;
}

message ListPendingCommitmentPlanApprovalsResponse {
repeated PendingCommitmentPlanApproval approvals = 1;
}
Loading
Loading