Skip to content

Auto PR: Differences detected#36

Open
github-actions[bot] wants to merge 1 commit intomainfrom
predefined_de/autopr_1769182491
Open

Auto PR: Differences detected#36
github-actions[bot] wants to merge 1 commit intomainfrom
predefined_de/autopr_1769182491

Conversation

@github-actions
Copy link
Contributor

Automated PR: Differences detected between the existing file and the generated content.

"designs": [
{
"id": "-",
"title": "Agilex 7 FPGA - TinyML LiteRT Example Design Example on Nios® V/g Processor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "System Example Design"

"patch_number": "Unknown",
"devkit": "Agilex® 7 FPGA F-Series Development Kit P-Tile and E-Tile DK-DEV-AGF014EA",
"device_part": "AGFB014R24B2E2V",
"description": "Nios® V/g Processor-based TinyML LiteRT example design on the Agilex® 7 FPGA.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again should be "System Exmaple Design"

}
],
"Q_DOWNLOAD_URL": "https://api.github.com/repos/altera-fpga/agilex7f-nios-ed/releases/assets/344658973",
"Q_GITHUB_RELEASE": "25.3.1-v1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have v1.0 here? We are trying to have consistent naming convention. Can we have first version as 25.3.1 as release tag? If there are any more then you can add versions.

},
{
"id": "-",
"title": "Agilex 7 FPGA - Nios V/m Transceiver Loopback design",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be "Agilex 7 FPGA Nios V/m Transceiver Loopback System Example Design"

"patch_number": "Unknown",
"devkit": "Agilex 7 FPGA F-Series Development Kit 2xF-Tile DK-DEV-AGF027F1ES",
"device_part": "AGFD023R24C2E1VC",
"description": "F-Tile Transceiver loopback design on Agilex™ 7 FPGA F-Series Development Kit (2xF-Tile)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System Example Design

}
],
"Q_DOWNLOAD_URL": "https://api.github.com/repos/altera-fpga/agilex7f-nios-ed/releases/assets/344685849",
"Q_GITHUB_RELEASE": "25.3.1-v1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25.3.1

},
{
"id": "-",
"title": "Agilex 7 FPGA - Lockstep Example Design Example on Nios® V/g Processor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be Example Design Example.....should be System Example Design

"patch_number": "Unknown",
"devkit": "Agilex® 7 FPGA F-Series Development Kit P-Tile and E-Tile DK-DEV-AGF014EA",
"device_part": "AGFB014R24B2E2V",
"description": "Nios® V/g Processor-based Lockstep example design on the Agilex® 7 FPGA.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

System Example Design

}
],
"Q_DOWNLOAD_URL": "https://api.github.com/repos/altera-fpga/agilex7f-nios-ed/releases/assets/344655307",
"Q_GITHUB_RELEASE": "25.3.1-v1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, we need consistent naming convention

},
{
"id": "-",
"title": "Agilex 7 FPGA - Lockstep Example Design Example on Nios V/g Processor",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This says Example Design Example.....needs to be System Example Design

Copy link
Contributor

@cohensus cohensus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments in code to resolve

@nithinkumark94
Copy link

Updated the list.json file based on the review comments. Kindly review
https://github.com/altera-fpga/agilex7f-nios-ed/releases/download/25.3.1/list.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants