Fix date-shaped identifier misparsing in PROV-N and silent skipping of malformed PROV-JSON record bodies#20
Merged
amateescu merged 1 commit intoJul 6, 2026
Conversation
…f malformed PROV-JSON record bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
shape (e.g.
2024-01-15T100000) was parsed as aDateTimeImmutablewhenever it matched that shape, regardless of grammar position. An
identifier like
entity(2024-01-15T100000)reused inwasGeneratedBy'sentity slot would silently come back as a date instead of an identifier.
Only the grammar position (
$expectTime), not the token shape, can tellan identifier from a datetime — the check now gates on that.
assertRecordBody(). A scalar record body such as{"entity":{"ex:e1":"notamap"}}was silently skipped (if (!is_array($instance)) continue;).It now throws
DeserializationException, matching how other malformedPROV-JSON shapes are already handled. Covers entity/activity/agent
records and both scruffy-list and single-instance relation bodies.
character class ordering; no behavior change.
key/merging rules (unifying records that share an identifier across a
document), distinct from the transitive graph reasoning rules
(31-32, 35, 41-49) that are the rest of the unsupported set.
subject formal is omitted from output, since JSON-LD attaches a relation
as a property of its subject node.