Build and test cp312 wheels for far-unitree-sdk#13
Merged
Conversation
The manylinux_2_28 image cibuildwheel 2.21.3 pins (2024.10.07-1) ships a cp312 interpreter, so building cp312 wheels needs no image bump. Widen the build set and the CI import-test matrix, lift the requires-python cap to <3.13 so pip selects the new wheels, and bump the release version. - pyproject: build add cp312-*; requires-python >=3.8,<3.13; version 0.1.4 - release.yml: test_wheels matrix add "3.12"; refresh stale TestPyPI comments - uv.lock: synced (version 0.1.4, requires-python <3.13) - PUBLISHING.md / deploy/test_docker.sh: example tag/wheel names -> 0.1.4, drop stale TestPyPI mention
clayrosenthal
force-pushed
the
clayros/py312-wheels
branch
from
22a45da to
da58677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add Python 3.12 (cp312) to the wheel build set and the CI import-test matrix, and lift the
requires-pythoncap from<3.12to<3.13.Why
The build was previously capped at cp311 during review to make
requires-pythonmatch the built wheel set. Booster already builds cp312; this brings unitree to parity sopip install far-unitree-sdkworks on Python 3.12.Changes
pyproject.toml:[tool.cibuildwheel] buildaddscp312-*;requires-python = ">=3.8,<3.13"; comment updated..github/workflows/release.yml:test_wheelsmatrix adds"3.12".uv.lock:requires-pythonsynced to<3.13(one line, no package churn).Verification
manylinux_2_28(2024.10.07-1) ships a cp312 interpreter (verified viadocker run … ls /opt/python— cp38–cp312 all present), so cp38 wheels keep building and cp312 is available.cibw_before_build.shhook is interpreter-agnostic (compiles pybind11 against whatever Python cibuildwheel activates), so no script change is required.python:3.12-slimtest image is bookworm (glibc 2.36), which satisfies the manylinux_2_31 floor.Note: CI only fires on tag-push / manual dispatch, so no checks will appear on this PR until a
v*tag or a manual 'Run workflow'.