Ship .pyi type stub deterministically + guard py.typed#14
Merged
Conversation
The published wheels shipped py.typed without a .pyi stub (pybind11-stubgen ran best-effort/silently-non-fatal while py.typed was touched unconditionally), so mypy saw a typed-but-empty module and reported attr-defined on every symbol downstream (broke holosoma static checks). - cibw_before_build.sh: stage the committed python_binding/unitree_interface.pyi deterministically; stubgen only as a fallback that must produce a file; hard guard refusing to write py.typed without a .pyi (exit 1). - unitree_interface.pyi: fix 5 latent stub bugs (3 zero-member enums -> X=..., 3 __init__ overloads -> @overload). - version 0.1.4 -> 0.1.5 (pyproject + uv.lock).
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
The published wheels shipped py.typed without a .pyi stub (pybind11-stubgen ran best-effort/silently-non-fatal while py.typed was touched unconditionally), so mypy saw a typed-but-empty module and reported attr-defined on every symbol downstream (broke holosoma static checks).