Skip to content

Update README.md #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterdlarsen wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update README.md #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ def add(context, event) -> int:

@function
def get_sources(context, event) -> List[str]:
while True:
Copy link
Copy Markdown
Owner

@amazr amazr Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Adding an infinite loop with while True: in the get_sources function is a terrible idea unless you have a very specific reason for it. This will cause the function to run indefinitely, which is likely not what you want. Please reconsider this change."

print("hello world")
return context["sources"].keys()
```

Expand Down Expand Up @@ -386,4 +388,4 @@ By default, the logs emitted from within the `compute_modules` library have a le
from compute_modules.logging import set_internal_log_level

set_internal_log_level(logging.DEBUG)
```
```