fix(ci): use correct label name in screenshots workflow#1430
fix(ci): use correct label name in screenshots workflow#1430jeremyeder wants to merge 3 commits intomainfrom
Conversation
The workflow used --label "docs" but the repo label is "documentation". This caused the scheduled screenshot PR creation to fail with "could not add label: 'docs' not found". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
📝 WalkthroughWalkthroughUpdates a GitHub Actions workflow to change PR labels from Changes
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/screenshots.yml (1)
24-24: 🛠️ Refactor suggestion | 🟠 MajorPin all actions to specific commit SHAs.
The workflow uses semantic version tags (
@v6,@master) instead of commit SHAs for actions/checkout, actions/setup-node, actions/upload-artifact, and kubeflow/pipelines. This introduces supply chain risk if tags are moved or compromised. Pin to these SHAs:
actions/checkout@v6→de0fac2e4500dabe0009e67214ff5f5447ce83ddactions/setup-node@v6→48b55a011bda9f5d6aeb4c2d9c7362e8dae4041eactions/upload-artifact@v6→b7c566a772e6b6bfb58ed0dc250532a479d7789fkubeflow/pipelines/.github/actions/github-disk-cleanup@master→8b27aca612c83881de75baf6815fdd566b154ef3Applies to lines 24, 27, 30, and 113.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/screenshots.yml at line 24, Replace the loose semantic tags with the provided commit SHAs to pin the actions and remove supply-chain risk: update actions/checkout@v6 to actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd, actions/setup-node@v6 to actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e, actions/upload-artifact@v6 to actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f, and kubeflow/pipelines/.github/actions/github-disk-cleanup@master to kubeflow/pipelines/.github/actions/github-disk-cleanup@8b27aca612c83881de75baf6815fdd566b154ef3 so the workflow references immutable SHAs instead of moving tags.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/screenshots.yml:
- Line 24: Replace the loose semantic tags with the provided commit SHAs to pin
the actions and remove supply-chain risk: update actions/checkout@v6 to
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd, actions/setup-node@v6
to actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e,
actions/upload-artifact@v6 to
actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f, and
kubeflow/pipelines/.github/actions/github-disk-cleanup@master to
kubeflow/pipelines/.github/actions/github-disk-cleanup@8b27aca612c83881de75baf6815fdd566b154ef3
so the workflow references immutable SHAs instead of moving tags.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 52a6b725-e44f-4e96-8930-5a52a4e5447c
📒 Files selected for processing (1)
.github/workflows/screenshots.yml
Summary
--label "docs"but the repo label isdocumentationgh pr createto fail withcould not add label: 'docs' not foundTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit