Fix: deprecation message for Monolog-RCE{8, 9} and a few changes ...

[mir-hossein]

Hello,

Monolog/RCE{8,9} generated a deprecation message because of a typo.

The issue has been solved now, and a few changes have been made.

Thank you for sharing PHPGGC!

[nollium]

Thank you for the submission!
I'll be looking into it this week.

In the meantime, could you shortly clarify why this specific change is necessary ? (picture attached)

Thanks again :)

[mir-hossein]

Hello,

mixed is data type for formatted property. Years ago when I was trying to submit a PR, incorrectly I selected mixed instead of formatted. It worked correctly but later, in new PHP versions (PHP >= 8.2), PHP generates deprecation message when a property doesn't exist. To avoid the deprecation message, I updated it to fix the problem.

    class LogRecord
    {
        public Level $level;
        public mixed $formatted;
        
        function __construct($parameter)
        {
            $this->level = \Monolog\Level::Debug;
            $this->formatted = $parameter;
        }
    }

Even without the changes, the GC will work but a deprecation message will be generated in PHP >=8.2.

PHP 8.1:

php8.1 ./phpggc monolog/RCE8 --test-payload
Trying to deserialize payload...
SUCCESS: Payload triggered !

PHP 8.4:

./phpggc monolog/RCE8 --test-payload
Trying to deserialize payload...
PHP Deprecated:  Creation of dynamic property GadgetChain\Monolog\RCE8::$__test_rand_token is deprecated in /tmp/PHPGGC-monolog/phpggc/lib/PHPGGC/GadgetChain/RCE.php on line 21
PHP Deprecated:  Creation of dynamic property GadgetChain\Monolog\RCE8::$__test_rand_path is deprecated in /tmp/PHPGGC-monolog/phpggc/lib/PHPGGC/GadgetChain/RCE.php on line 22
PHP Deprecated:  Creation of dynamic property Monolog\LogRecord::$mixed is deprecated in /tmp/PHPGGC-monolog/phpggc/gadgetchains/Monolog/RCE/8/gadgets.php on line 18
PHP Deprecated:  Creation of dynamic property Monolog\LogRecord::$mixed is deprecated in /tmp/PHPGGC-monolog/phpggc/lib/test_payload.php on line 46
SUCCESS: Payload triggered !