Fix Guzzle/FW1 - FileCookieJar chain was broken#226
Open
TrekLaps wants to merge 1 commit intoambionics:masterfrom
Open
Fix Guzzle/FW1 - FileCookieJar chain was broken#226TrekLaps wants to merge 1 commit intoambionics:masterfrom
TrekLaps wants to merge 1 commit intoambionics:masterfrom
Conversation
The existing chain passed $data as 2nd constructor argument, but FileCookieJar::__construct() signature is: __construct(string $cookieFile, bool $storeSessionCookies = false) The 2nd parameter is a boolean, not the data to write. This fix: - Properly creates SetCookie objects with the payload - Uses reflection to set the cookies array - Tested on Guzzle 7.10.0 / PHP 8.4.17 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing chain passed $data as 2nd constructor argument, but FileCookieJar::__construct() signature is:
__construct(string $cookieFile, bool $storeSessionCookies = false)
The 2nd parameter is a boolean, not the data to write.
This fix: