perf(query): remove need for external dependency#20
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes the external qs dependency and replaces it with a custom stringify implementation to handle query parameter serialization. This change aims to improve performance by eliminating an external dependency.
Changes:
- Implemented custom
stringifyfunction to replaceqs.stringifyfunctionality - Added
IStringifyQueryOptionsinterface to define configuration options - Removed
qspackage dependency from package.json and pnpm-lock.yaml - Added comprehensive tests for the new stringify options (maxDepth, skipNulls, separator)
- Updated API documentation to reflect the new optional parameters
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/url.ts | Implements custom stringify function with recursive encoding logic and adds options parameter to setQueryParams |
| types/index.ts | Defines IStringifyQueryOptions interface for query stringification configuration |
| tests/url.spec.ts | Adds tests for new options (maxDepth, skipNulls, separator) and nested object handling |
| package.json | Removes qs dependency |
| pnpm-lock.yaml | Removes qs and its transitive dependencies |
| docs/api.md | Updates setQueryParams documentation to include options parameter |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@bnachtweh I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.