Fix: remove hard-coded x86 flags in Makefile#77
Open
alessandroamella wants to merge 1 commit intoamchess:masterfrom
Open
Fix: remove hard-coded x86 flags in Makefile#77alessandroamella wants to merge 1 commit intoamchess:masterfrom
alessandroamella wants to merge 1 commit intoamchess:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hard-coded flags
-mprefer-vector-width=256and-mno-avx512finside Makefile caused build failures on non-x86 architectures such as ARMv8.This change allows the project to build correctly on multiple architectures (tested on ARMv8 / Apple Silicon on Asahi Linux), by removing the hard-coded x86-specific compiler flags and adding a conditional check so they are only applied on x86 architectures: