Skip to content

ci: check out trusted base in pr-comment, not the fork head_sha #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atassis wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

ci: check out trusted base in pr-comment, not the fork head_sha #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/pr-comment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,13 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v4
with:
ref: ${{ github.event.workflow_run.head_sha }}
# No ref: check out the default branch (trusted base code). This job
# runs from workflow_run with a write-scoped GITHUB_TOKEN and secrets,
# so it must not check out the fork's head_sha: actions/checkout now
# refuses that (pwn-request guard), and running the fork's copy of
# ci/scripts/pretty_aggregate.py under the write token would be the
# vulnerability itself. The job only needs the trusted aggregation
# script; artifacts and PR metadata come from the API, not the tree.

- name: Set up Python
uses: actions/setup-python@v5
Expand Down