gelu: re-enable the tile_size=8192 test#141
Open
atassis wants to merge 1 commit into
Open
Conversation
Closes amd#113. amd#113 disabled this case pending the LUT alignment fix in mlir-aie PR #3045 ("Fix alignment for look up tables"), which has since merged. That fix is present in the mlir_aie version pinned here: #3045 merged as 6032217 (2026-05-11), requirements.txt pins mlir_aie==1.3.5.dev20+g167f34d (167f34d, 2026-07-08), and 6032217 is an ancestor of 167f34d. Locally the case passes: the parameter set generates exactly one tile_size=8192 config (input_length=8192, 1 column, 1 channel), it passed 5/5 standalone, and the full gelu suite is green with the skip removed (160 passed on Strix). Worth noting this test is marked extensive (is_extensive = input_length != 2048) and the extensive workflows run on push/schedule rather than pull_request, so PR CI will not exercise it. A workflow_dispatch run of phoenix-extensive or krackan-extensive on this branch would confirm it before merge. _marks no longer needs the tile size, so it takes only the extensive flag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR B -- amd/IRON, branch
fix/reenable-gelu-tile-8192@2ad1a4d(basedevel)Title: gelu: re-enable the tile_size=8192 test
Closes #113.
#113 disabled this case pending the LUT alignment fix in
mlir-aie #3045 ("Fix alignment for look up tables"),
which has since merged.
That fix is in the
mlir_aieversion pinned here, so CI already has it:6032217(2026-05-11)requirements.txtpinsmlir_aie==1.3.5.dev20+g167f34d(167f34d, 2026-07-08)git merge-base --is-ancestor 6032217 167f34d-> yesTesting
Validated against the pinned toolchain rather than a local build: a fresh venv with
pip install -r requirements.txt(somlir_aie==1.3.5.dev20+g167f34dandllvm-aie==21.0.0.2026062301+cb664e8c, exactly what CI installs), cold JIT cache, on Strix/NPU2.The parameter set generates exactly one
tile_size=8192config (input_length=8192, 1 column,1 channel). 160 passed for the full
gelusuite, 40/40 for the8192selection.One caveat worth flagging: this test is marked
extensive(is_extensive = input_length != 2048),and the extensive workflows trigger on
push/schedulerather thanpull_request-- so PR CIwon't exercise it. If you'd like confirmation before merging, a
workflow_dispatchrun ofphoenix-extensiveorkrackan-extensiveon this branch is the only pre-merge signal available._marksno longer needs the tile size, so it takes only the extensive flag.