[speech2speech] Re-Writing README.md by introducing HaloBox into OS Environment setup#254
Open
ldokovic-personal wants to merge 2 commits into
Open
[speech2speech] Re-Writing README.md by introducing HaloBox into OS Environment setup#254ldokovic-personal wants to merge 2 commits into
ldokovic-personal wants to merge 2 commits into
Conversation
Collaborator
|
@sreeram-11 Can you help review this PR? |
danielholanda
changed the title
…. Additional fix on /Paths for gradio.py and infer.py scripts.
…maintain a neat UI for OS's and GPU architectures
ldokovic-personal
force-pushed
the
ldokovic/speech2speech-translation-ReadMe
branch
from
78a7117 to
36739e0
Compare
Collaborator
Author
|
Per my point of view, it requires an update on CICD test if we decide to stay on this approach. I think it's much better for Users to define ENV VAR. model path once globally (leaving him the freedom to decide on the path) instead aligning with pipeline test. So, test_verify-local-model-assets.py needs to be modified so it expects ENV.VARIABLE in yaml before overwriting path value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the README file to incorporate tested fixes specifically for the Linux OS.
The modifications include:
Added overall clarifications on the steps specific to the Linux OS and some Windows commands.
All changes are based on the issues addressed in the attached report https://amdcloud-my.sharepoint.com/:w:/g/personal/ldokovic_amd_com/IQArvsiZS7veRK76HdwPD1stAfAbEYxs6dLuAwO90o0gfeM?e=LKg6Du