Skip to content

update userdefaults #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amine2233 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update userdefaults #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions Sources/CombineExtensionUserDefaults/UserDefaults/CombineUserDefaultOnChange.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,32 +35,34 @@ public extension Publishers {

extension Publishers.DefaultsObservation {
private final class SubscriptionDefaultsObservation<S: Subscriber, T: PropertyListValue>: NSObject, Subscription where S.Input == T? {
private var subscriber: S?
private var subscriber: S
private var key: UserDefaultsKey
private var isDisposed: Bool = false
private var userDefaults: UserDefaults

init(subscriber: S, userDefaults: UserDefaults, key: UserDefaultsKey) {
init(
subscriber: S,
userDefaults: UserDefaults,
key: UserDefaultsKey
) {
self.subscriber = subscriber
self.userDefaults = userDefaults
self.key = key
super.init()
configure()
userDefaults.addObserver(self, forKeyPath: key.rawValue, options: [.new], context: nil)
}

func request(_: Subscribers.Demand) {}

func configure() {
userDefaults.addObserver(self, forKeyPath: key.rawValue, options: [.new], context: nil)
}

// swiftlint:disable block_based_kvo
override func observeValue(forKeyPath keyPath: String?,
of object: Any?,
change: [NSKeyValueChangeKey: Any]?,
context _: UnsafeMutableRawPointer?) {
override func observeValue(
forKeyPath keyPath: String?,
of object: Any?,
change: [NSKeyValueChangeKey: Any]?,
context _: UnsafeMutableRawPointer?
) {
guard let change = change, object != nil, keyPath == key.rawValue else { return }
_ = subscriber?.receive(change[.newKey] as? T)
_ = subscriber.receive(change[.newKey] as? T)
}

// swiftlint:enable block_based_kvo
Expand All @@ -69,7 +71,7 @@ extension Publishers.DefaultsObservation {
if !isDisposed {
userDefaults.removeObserver(self, forKeyPath: key.rawValue, context: nil)
isDisposed = true
subscriber?.receive(completion: .finished)
subscriber.receive(completion: .finished)
}
}
}
Expand Down