Skip to content
This repository was archived by the owner on Jun 11, 2026. It is now read-only.

Proposal: stop having separate FileResourceLoader implementations per platform and rely on FileSystem instead.#396

Open
tomsfernandez wants to merge 1 commit into
developfrom
file-rl-proposal
Open

Proposal: stop having separate FileResourceLoader implementations per platform and rely on FileSystem instead.#396
tomsfernandez wants to merge 1 commit into
developfrom
file-rl-proposal

Conversation

@tomsfernandez

@tomsfernandez tomsfernandez commented Dec 28, 2021

Copy link
Copy Markdown
Contributor

Objective: have a way to unit-test the adapter logic inside the ResourceLoader implementations from a "shared" scala test suite.

  • This is also helpful to mock the "FileSystem" object and "spy" on the end products of AMF's uri-resolution mechanism. This is especially useful when debugging APIKIT Api Sync error cases.

Concerns

  • The only concern I have is regarding performance between the JvmFileSystem implementations and the legacy file reading mechanism. Unfortunately I don't see a way to easily benchmark this as disk I/O will affect the measurement a lot.

Note: this small refactor is made to be fully backwards compatible with the previous implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants