Add postlexer to support multiline binary operators and ternary expressions#270
Merged
kkozik-amplify merged 1 commit intorelease/8.xfrom Mar 11, 2026
Merged
Add postlexer to support multiline binary operators and ternary expressions#270kkozik-amplify merged 1 commit intorelease/8.xfrom
kkozik-amplify merged 1 commit intorelease/8.xfrom
Conversation
kkozik-amplify
force-pushed
the
multiline-exprs
branch
from
ba0039f to
c9a10d9
Compare
rddimon
reviewed
Mar 10, 2026
Comment on lines
104
to
108
| 1. Add grammar rules to `hcl2.lark` | ||
| 1. If the new construct creates LALR ambiguities with `NL_OR_COMMENT`, add a postlexer pass in `postlexer.py` | ||
| 1. Create rule class(es) in the appropriate `rules/` file | ||
| 1. Add transformer method(s) in `transformer.py` | ||
| 1. Implement `serialize()` in the rule class |
Contributor
There was a problem hiding this comment.
Is it possible to fix numeric?
Collaborator
Author
There was a problem hiding this comment.
Hmm weird. Numbers were automatically changed to 1. by markdown format pre-commit hook. Funnily enough it looks fine in the reading view
Apparently its the recommended practice
typora/typora-issues#1188
rddimon
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #269 and #142