Fix newly reported PHPStan errors#576
Merged
Merged
Conversation
swissspidy
added
the
Testing
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets newly reported PHPStan issues across the codebase by tightening type expectations and removing/adjusting problematic patterns to satisfy static analysis.
Changes:
- Fix
unserialize()options usage to correctly restrict allowed classes when reading cached responses. - Add runtime/type guards in DOM processing code to satisfy PHPStan and avoid calling element-only APIs on non-elements.
- Clean up PHPStan configuration and add local type annotations (e.g., for
$argv) to reduce analysis noise.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/RemoteRequest/TemporaryFileCachedRemoteGetRequest.php | Updates unserialize() to use the correct allowed_classes option format. |
| src/Dom/Document/Filter/MustacheScriptTemplates.php | Adds a DOMElement type guard before calling setAttribute() on an attribute’s parent node. |
| src/Dom/Document/Filter/DeduplicateTag.php | Removes a redundant conditional around caching the main head/body tag reference. |
| src/Cli/Options.php | Adds a PHPStan-friendly local type annotation for global $argv. |
| phpstan.neon.dist | Removes an ignore rule related to set_exception_handler() type expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+132
to
136
| if ($attribute->parentNode instanceof DOMElement) { | ||
| $attribute->parentNode->setAttribute($attribute->nodeName, $value); | ||
| } | ||
|
|
||
| $this->mustacheTagsReplaced = true; |
Comment on lines
11
to
13
| ignoreErrors: | ||
| - '#^PHPDoc tag @throws with type AmpProject\\Exception\\FailedRemoteRequest is not subtype of Throwable$#' | ||
| - '#^Parameter \#1 (\$exception_handler|\$callback) of function set_exception_handler expects#' | ||
| excludePaths: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.