Prevent paired browsing client script from being sanitized#6099
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6099 +/- ##
=============================================
- Coverage 74.91% 74.89% -0.02%
Complexity 5775 5775
=============================================
Files 231 231
Lines 17487 17491 +4
=============================================
Hits 13100 13100
- Misses 4387 4391 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
Plugin builds for d14b3fd are ready 🛎️!
|
westonruter
approved these changes
Apr 23, 2021
Member
westonruter
left a comment
westonruter
left a comment
There was a problem hiding this comment.
I switched the dev environment for amp-wp.org to Transitional mode and confirmed that this validation error is now showing up. This PR does fix the issue.
Member
|
QA Passed There is no longer a validation error being detected when a site is in Transitional mode:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Gutenberg v9.9 the
wp-i18nscript is now dependent on thewp-hooksscript (see WordPress/gutenberg#27966). This has now caused a validation error to occur for the paired browsing client script aswp-hooksis not apart of the list of dependencies to mark with thedata-ampdevmodeattribute. This PR fixes that.Aside: We may want to give higher priority to #4001 since we didn't immediately catch this.
Checklist