Fix polyfill dependency issues on WP 4.9#6119
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #6119 +/- ##
=============================================
- Coverage 75.03% 75.02% -0.01%
Complexity 5829 5829
=============================================
Files 232 232
Lines 17618 17619 +1
=============================================
Hits 13219 13219
- Misses 4399 4400 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
Plugin builds for e35a71b are ready 🛎️!
|
delawski
approved these changes
Apr 27, 2021
Collaborator
delawski
left a comment
There was a problem hiding this comment.
@pierlon Thank you for fixing this bug. Everything is working well for me both on 4.9.8 and on 5.7.1
| WP 4.9.8 | WP 5.7.1 |
|---|---|
![]() |
![]() |
Also, the Validated URL and Error Index counts show values on version 4.9.8 (which wasn't the case before).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Fixes #6100
The
wp-i18nscript now depends onwp-hooks(see WordPress/gutenberg#27966), so that dependency is now polyfilled. Also, this PR ensures dependencies for thewp-api-fetchscript are being registered, which they previously were not.This PR also enqueues the polyfills before loading any assets for the
amp-validation-countshandle.Demo
20210426201040.mp4
Checklist