Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f03eb99
Update Gutenberg package dependencies
ampprojectbot Jan 5, 2023
8171617
Bump React and ReactDOM to 18.2.0
thelovekesh Dec 15, 2022
c81da17
Bump react-test-renderer to 18.2.0
thelovekesh Dec 16, 2022
b3f7312
Add @testing-library/react
thelovekesh Dec 15, 2022
976e0ed
Refactor test cases to implement `@testing-library/react`
thelovekesh Dec 15, 2022
c10ef7e
Update jest snapshots
thelovekesh Dec 16, 2022
4ea4bef
Use mocked DOM events from testing-library
thelovekesh Dec 16, 2022
1ae712d
Update package-lock.json
thelovekesh Jan 9, 2023
c3c26da
Fix the order of devDependencies
thelovekesh Jan 9, 2023
d0c6221
update(react-18): migrate render to createRoot with strict mode in se…
thelovekesh Jan 10, 2023
35e438c
update(react-18): migrate render to createRoot with strict mode in on…
thelovekesh Jan 10, 2023
40fa3c6
update(react-18): migrate render to createRoot with strict mode in su…
thelovekesh Jan 10, 2023
9c6d30e
update(react-18): migrate render to createRoot with strict mode in si…
thelovekesh Jan 10, 2023
d8028c7
Fix bug due to improper effect unmount in useDelayedFlag hook
thelovekesh Jan 10, 2023
ec0a56d
Remove StrictMode
thelovekesh Jan 10, 2023
6c807d8
Add build step for ampSiteScanNotice to include @wordpress/element in…
thelovekesh Jan 10, 2023
61abd2f
Merge branch 'develop' into update/gutenberg-v14.9.0-packages
thelovekesh Jan 11, 2023
4eff56a
Remove postcss-loader from Dependabot ignore list
thelovekesh Jan 13, 2023
eb0d8c8
Remove postcss-nested from Dependabot ignore list
thelovekesh Jan 13, 2023
b6f8dfe
Bump postcss-nested to 6.0.0
thelovekesh Jan 13, 2023
06d608c
Remove copy-webpack-plugin from Dependabot ignore list
thelovekesh Jan 13, 2023
bae553c
Bump copy-webpack-plugin to 11.0.0
thelovekesh Jan 13, 2023
6196e12
Remove terser-webpack-plugin from Dependabot ignore list
thelovekesh Jan 13, 2023
396f9b4
Update react version in Dependabot ignore list
thelovekesh Jan 13, 2023
e05cb71
Remove react and react-dom
thelovekesh Jan 13, 2023
32b310f
Update package-lock.json
thelovekesh Jan 13, 2023
13dc871
Merge branch 'develop' into update/gutenberg-v14.9.0-packages
thelovekesh Jan 13, 2023
439a249
Update code formatting using prettier
thelovekesh Jan 13, 2023
974b776
Add code formatting commit for .md and .yml files
thelovekesh Jan 13, 2023
6d2e32b
Remove react from Dependabot ignore list
thelovekesh Jan 13, 2023
cdbc29e
Remove postcss-loader
thelovekesh Jan 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
# Apply Prettier formatting <https://github.com/ampproject/amp-wp/pull/7274>
614e495726bce56983b4c5dc948bac557afb4565

# Apply Prettier formatting in .github directory and .md files.
439a249543886306c91aace8a0ab7db2dc70a812
240 changes: 120 additions & 120 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,125 +1,125 @@
name: 🐛 Bug report
description: Create a report to help us improve.
labels:
- Bug
- Bug

body:
- type: textarea
attributes:
label: Bug Description
description: Please describe clearly and concisely what the bug is.
validations:
required: true

- type: textarea
attributes:
label: Expected Behaviour
description: Please describe clearly and concisely what the expected behaviour should be.
validations:
required: true

- type: textarea
attributes:
label: Screenshots
description: >
Please provide detailed steps on how to reproduce the bug. Provide a URL where the issue can be seen on the
frontend when possible, otherwise go to “View source” in the browser and copy all to paste in a
[Gist](https://gist.github.com/) and share it.

- type: input
attributes:
label: PHP Version
description: Specify which PHP version the bug occurs on.
placeholder: e.g. 8.1
validations:
required: false

- type: input
attributes:
label: Plugin Version
description: Specify which plugin version the bug occurs on.
placeholder: e.g. 2.1.4
validations:
required: true

- type: dropdown
attributes:
label: AMP plugin template mode
description: Specify which template mode the bug occurs on.
multiple: true
options:
- Standard
- Transitional
- Reader
validations:
required: true

- type: input
attributes:
label: WordPress Version
description: If applicable, specify which WordPress version the bug occurs on.
placeholder: e.g. 5.8

- type: textarea
attributes:
label: Site Health
description: >
If you would like to, please provide your Site Health information. You can also submit it privately via our
[AMP Plugin Escalations form](https://docs.google.com/forms/d/1JTQmphDlk9YgHpDoFRbHXpkDqv8-QmzTT7MDR4AstyQ).

- type: input
attributes:
label: Gutenberg Version
description: If applicable, specify which Gutenberg version the bug occurs on.
placeholder: e.g. 11.2.1

- type: input
attributes:
label: OS(s) Affected
description: If applicable, specify which operating system(s) are affected.
placeholder: e.g. Windows, Android

- type: input
attributes:
label: Browser(s) Affected
description: If applicable, specify which browser(s) are affected.
placeholder: e.g. Chrome, Firefox

- type: input
attributes:
label: Device(s) Affected
description: If applicable, specify which device(s) are affected.
placeholder: e.g. iPhone 12, Pixel 5

- type: markdown
attributes:
value: |
---
_**Do not alter anything below. The following fields will be managed by moderators only.**_

- type: textarea
attributes:
label: Acceptance Criteria
description: One or more bullet points for acceptance criteria.

- type: textarea
attributes:
label: Implementation Brief
description: >
One or more bullet points for how to technically resolve the issue. For significant Implementation Design,
it is ok use a Google document **accessible by anyone**.

- type: textarea
attributes:
label: QA Testing Instructions
description: One or more bullet points to describe how to test the implementation in QA.

- type: textarea
attributes:
label: Demo
description: A video or screenshots demoing the implementation.

- type: textarea
attributes:
label: Changelog Entry
description: One sentence summarizing the PR, to be used in the changelog.
- type: textarea
attributes:
label: Bug Description
description: Please describe clearly and concisely what the bug is.
validations:
required: true

- type: textarea
attributes:
label: Expected Behaviour
description: Please describe clearly and concisely what the expected behaviour should be.
validations:
required: true

- type: textarea
attributes:
label: Screenshots
description: >
Please provide detailed steps on how to reproduce the bug. Provide a URL where the issue can be seen on the
frontend when possible, otherwise go to “View source” in the browser and copy all to paste in a
[Gist](https://gist.github.com/) and share it.

- type: input
attributes:
label: PHP Version
description: Specify which PHP version the bug occurs on.
placeholder: e.g. 8.1
validations:
required: false

- type: input
attributes:
label: Plugin Version
description: Specify which plugin version the bug occurs on.
placeholder: e.g. 2.1.4
validations:
required: true

- type: dropdown
attributes:
label: AMP plugin template mode
description: Specify which template mode the bug occurs on.
multiple: true
options:
- Standard
- Transitional
- Reader
validations:
required: true

- type: input
attributes:
label: WordPress Version
description: If applicable, specify which WordPress version the bug occurs on.
placeholder: e.g. 5.8

- type: textarea
attributes:
label: Site Health
description: >
If you would like to, please provide your Site Health information. You can also submit it privately via our
[AMP Plugin Escalations form](https://docs.google.com/forms/d/1JTQmphDlk9YgHpDoFRbHXpkDqv8-QmzTT7MDR4AstyQ).

- type: input
attributes:
label: Gutenberg Version
description: If applicable, specify which Gutenberg version the bug occurs on.
placeholder: e.g. 11.2.1

- type: input
attributes:
label: OS(s) Affected
description: If applicable, specify which operating system(s) are affected.
placeholder: e.g. Windows, Android

- type: input
attributes:
label: Browser(s) Affected
description: If applicable, specify which browser(s) are affected.
placeholder: e.g. Chrome, Firefox

- type: input
attributes:
label: Device(s) Affected
description: If applicable, specify which device(s) are affected.
placeholder: e.g. iPhone 12, Pixel 5

- type: markdown
attributes:
value: |
---
_**Do not alter anything below. The following fields will be managed by moderators only.**_

- type: textarea
attributes:
label: Acceptance Criteria
description: One or more bullet points for acceptance criteria.

- type: textarea
attributes:
label: Implementation Brief
description: >
One or more bullet points for how to technically resolve the issue. For significant Implementation Design,
it is ok use a Google document **accessible by anyone**.

- type: textarea
attributes:
label: QA Testing Instructions
description: One or more bullet points to describe how to test the implementation in QA.

- type: textarea
attributes:
label: Demo
description: A video or screenshots demoing the implementation.

- type: textarea
attributes:
label: Changelog Entry
description: One sentence summarizing the PR, to be used in the changelog.
18 changes: 9 additions & 9 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
blank_issues_enabled: true
contact_links:
- name: ❓ Plugin Support Forum
url: https://wordpress.org/support/plugin/amp/
about: For plugin usage questions and compatibility issues with other plugins, please use the plugin's support forum. Before opening a new topic, please search the forum for existing topics as someone else has likely reported the issue already.
- name: ℹ️ AMP for WordPress
url: https://amp-wp.org/
about: Find documentation, a showcase of sites using the official AMP plugin, an ecosystem directory of compatible themes/plugins, and a blog with news on the plugin site.
- name: 📺 Video Series
url: https://www.youtube.com/playlist?list=PLXTOW_XMsIDRGRr5QDffrvND8Qh1RndFb
about: Check out our video series on YouTube for an introduction to the plugin and how you can leverage it on your site.
- name: ❓ Plugin Support Forum
url: https://wordpress.org/support/plugin/amp/
about: For plugin usage questions and compatibility issues with other plugins, please use the plugin's support forum. Before opening a new topic, please search the forum for existing topics as someone else has likely reported the issue already.
- name: ℹ️ AMP for WordPress
url: https://amp-wp.org/
about: Find documentation, a showcase of sites using the official AMP plugin, an ecosystem directory of compatible themes/plugins, and a blog with news on the plugin site.
- name: 📺 Video Series
url: https://www.youtube.com/playlist?list=PLXTOW_XMsIDRGRr5QDffrvND8Qh1RndFb
about: Check out our video series on YouTube for an introduction to the plugin and how you can leverage it on your site.
72 changes: 36 additions & 36 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -1,47 +1,47 @@
name: ✨ Feature request
description: Suggest an idea for this project.
labels:
- Enhancement
- Enhancement

body:
- type: textarea
attributes:
label: Feature Description
description: >
Please describe clear and concisely which problem the feature would solve or which publisher needs
it would address.
validations:
required: true
- type: textarea
attributes:
label: Feature Description
description: >
Please describe clear and concisely which problem the feature would solve or which publisher needs
it would address.
validations:
required: true

- type: markdown
attributes:
value: |
---
_**Do not alter anything below. The following fields will be managed by moderators only.**_
- type: markdown
attributes:
value: |
---
_**Do not alter anything below. The following fields will be managed by moderators only.**_

- type: textarea
attributes:
label: Acceptance Criteria
description: One or more bullet points for acceptance criteria.
- type: textarea
attributes:
label: Acceptance Criteria
description: One or more bullet points for acceptance criteria.

- type: textarea
attributes:
label: Implementation Brief
description: >
One or more bullet points for how to technically resolve the issue. For significant Implementation Design,
it is ok use a Google document **accessible by anyone**.
- type: textarea
attributes:
label: Implementation Brief
description: >
One or more bullet points for how to technically resolve the issue. For significant Implementation Design,
it is ok use a Google document **accessible by anyone**.

- type: textarea
attributes:
label: QA Testing Instructions
description: One or more bullet points to describe how to test the implementation in QA.
- type: textarea
attributes:
label: QA Testing Instructions
description: One or more bullet points to describe how to test the implementation in QA.

- type: textarea
attributes:
label: Demo
description: A video or screenshots demoing the implementation.
- type: textarea
attributes:
label: Demo
description: A video or screenshots demoing the implementation.

- type: textarea
attributes:
label: Changelog Entry
description: One sentence summarizing the PR, to be used in the changelog.
- type: textarea
attributes:
label: Changelog Entry
description: One sentence summarizing the PR, to be used in the changelog.
5 changes: 3 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
## Summary

<!-- Please reference the issue(s) this PR fixes, if one exists. For significant changes, opening an issue first for discussion is usually preferable. -->

Fixes #

## Checklist

- [ ] My code is tested and passes existing [tests](https://github.com/ampproject/amp-wp/wiki/Engineering-Guidelines#tests).
- [ ] My code follows the [Engineering Guidelines](https://github.com/ampproject/amp-wp/wiki/Engineering-Guidelines) (updates are often made to the guidelines, check it out periodically).
- [ ] My code is tested and passes existing [tests](https://github.com/ampproject/amp-wp/wiki/Engineering-Guidelines#tests).
- [ ] My code follows the [Engineering Guidelines](https://github.com/ampproject/amp-wp/wiki/Engineering-Guidelines) (updates are often made to the guidelines, check it out periodically).
Loading